Unsigned and Signed#271
Draft
ktbarrett wants to merge 3 commits into
Draft
Conversation
ab25267 to
58d2fbc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #271 +/- ##
==========================================
+ Coverage 92.76% 92.84% +0.07%
==========================================
Files 23 23
Lines 1285 1285
Branches 312 312
==========================================
+ Hits 1192 1193 +1
Misses 34 34
+ Partials 59 58 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
58d2fbc to
58074e5
Compare
4454dc3 to
5529b4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191.
These are useful for implementing a bunch of features currently found in cocotb's
LogicArray(e.g.from_unsigned,to_unsigned) that we for binding coconext'sDynLogicArrayto Python in a way it can sit in place of cocotb's using the patcher.This just uses
uint64_tandint64_t. We will adaptUInt, andSIntfrom #278 once it's done.