Replace index and rindex methods with free functions#290
Merged
Conversation
First the name `index` collide with the static indexing method `index<I>()`, so this was changed to `index_of`, and the reverse lookup to `rindex_of` to match Python's 'r' prefix for reversed operations. Next I moved these to free functions scope on the `RangedSequence` concept as it has a generic implementation. We will figure out nicer method-like spellings and performance-based overloads later.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #290 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 23 23
Lines 1309 1309
Branches 316 316
=======================================
Hits 1205 1205
Misses 43 43
Partials 61 61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First the name
indexcollide with the static indexing methodindex<I>(), so this was changed toindex_of, and the reverse lookup torindex_ofto match Python's 'r' prefix for reversed operations.Next I moved these to free functions scope on the
RangedSequenceconcept as it has a generic implementation. We will figure out nicer method-like spellings and performance-based overloads later.