Make resolve and reduce methods free functions on LogicArray concept#291
Open
ktbarrett wants to merge 1 commit into
Open
Make resolve and reduce methods free functions on LogicArray concept#291ktbarrett wants to merge 1 commit into
ktbarrett wants to merge 1 commit into
Conversation
This reduces repetition, not only in code, but also in documentation. This follows the index_of and rindex_of becoming free functions on all RangedSequence.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #291 +/- ##
==========================================
+ Coverage 91.80% 91.88% +0.07%
==========================================
Files 23 23
Lines 1318 1318
Branches 330 330
==========================================
+ Hits 1210 1211 +1
Misses 45 45
+ Partials 63 62 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZiaCheemaGit
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces repetition, not only in code, but also in documentation. This follows the index_of and rindex_of becoming free functions on all RangedSequence. This will make documentation easier and makes it even more flexible to new types like
UnsignedandSigned.