Skip to content

Convert to ColorUtils#136

Merged
kuba6000 merged 2 commits into
kuba6000:masterfrom
Ranzuu:edit
Jun 7, 2026
Merged

Convert to ColorUtils#136
kuba6000 merged 2 commits into
kuba6000:masterfrom
Ranzuu:edit

Conversation

@Ranzuu

@Ranzuu Ranzuu commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

@Ranzuu Ranzuu requested a review from kuba6000 as a code owner June 7, 2026 17:01
@kuba6000

kuba6000 commented Jun 7, 2026

Copy link
Copy Markdown
Owner

@Ranzuu
Does this still use the same lang key or is it different now?

@Ranzuu

Ranzuu commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

@Ranzuu Does this still use the same lang key or is it different now?

Different
mobsinfo.
"color.resource." + modId + "." + name;"
color.resource.mobsinfo.textDefault=

GTNewHorizons/GTNHLib#380

@kuba6000

kuba6000 commented Jun 7, 2026

Copy link
Copy Markdown
Owner

@Ranzuu spotless,
Also you dont need to create a fork to make a pr to this repo, as a GTNH developer you can normally create your branch on GTNH fork but as a base branch just set it as upstream/master and not origin/master the same way as you did it from your fork now

@Ranzuu

Ranzuu commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

@Ranzuu spotless, Also you dont need to create a fork to make a pr to this repo, as a GTNH developer you can normally create your branch on GTNH fork but as a base branch just set it as upstream/master and not origin/master the same way as you did it from your fork now

Ah my bad, will do branch next time!

@kuba6000 kuba6000 enabled auto-merge (squash) June 7, 2026 17:10
@kuba6000 kuba6000 merged commit d1e9ad1 into kuba6000:master Jun 7, 2026
2 checks passed
@Ranzuu Ranzuu deleted the edit branch June 7, 2026 17:12
kuba6000 pushed a commit that referenced this pull request Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants