Switch to ColorUtils#138
Merged
Merged
Conversation
Owner
|
So this still doesn't require gtnhlib to be in the mods? And doesn't crash with gtnhlib in the mods? |
kuba6000
requested changes
Jun 13, 2026
kuba6000
approved these changes
Jun 14, 2026
kuba6000
left a comment
kuba6000
left a comment
Owner
There was a problem hiding this comment.
I wonder if it will cause any problems in the future, class loader might load older version of the class depending on which mod loads first because we are providing identical class names as in gtnhlib
Contributor
Author
Let's pray it won't. But if, we will fix it 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally correctly works
Fulllpack good, dev good, includes just one class from gtnhlib