Skip to content

fix(examples): add missing BaseDataSource import to RFNet/ERFNet sedna_predict.py files#539

Open
Aamod-Dev wants to merge 1 commit into
kubeedge:mainfrom
Aamod-Dev:fix-missing-basedatasource-import
Open

fix(examples): add missing BaseDataSource import to RFNet/ERFNet sedna_predict.py files#539
Aamod-Dev wants to merge 1 commit into
kubeedge:mainfrom
Aamod-Dev:fix-missing-basedatasource-import

Conversation

@Aamod-Dev

Copy link
Copy Markdown

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR adds the missing BaseDataSource import to multiple sedna_predict.py files in the RFNet/ERFNet examples.

Previously, these files instantiated BaseDataSource(data_type="test") in the pre_data_process() method but only imported IndexDataParse from sedna.datasources. If this execution path is hit without the import, it results in a NameError: name 'BaseDataSource' is not defined.

This commit adds BaseDataSource to the existing sedna.datasources import statement across the 5 affected files.

Which issue(s) this PR fixes:
Fixes #522

Special notes for your reviewer:
N/A

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 13, 2026
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates multiple sedna_predict.py files across different benchmark examples to import BaseDataSource alongside IndexDataParse from sedna.datasources. There are no review comments provided, so I have no additional feedback to offer.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Aamod-Dev

Copy link
Copy Markdown
Author

/assign @MooreZheng

…a_predict.py files

Signed-off-by: Aamod007 <aamodkumar2006@gmail.com>
@Aamod-Dev Aamod-Dev force-pushed the fix-missing-basedatasource-import branch from a6ca60a to 11b6194 Compare June 15, 2026 05:17
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aamod007
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Aamod-Dev

Copy link
Copy Markdown
Author

/assign @jaypume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Missing BaseDataSource import in sedna_predict.py across multiple RFNet example paths

4 participants