fix: replace hardcoded absolute paths with root-relative paths in RoboDK Palletizing example#543
fix: replace hardcoded absolute paths with root-relative paths in RoboDK Palletizing example#543Fahmid-Arman wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fahmid-Arman The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the RoboDK Palletizing single-task learning benchmark example by replacing absolute paths with relative paths, making the configuration self-contained and runnable from the repository root. It also updates the README instructions for downloading and unzipping the dataset. The feedback suggests adding a cd - command to the dataset setup script in the README to return the user to the repository root, ensuring the subsequent benchmarking command runs seamlessly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/assign @jaypume |
…oDK Palletizing example Signed-off-by: Fahmid Arman <fahmid.brac@gmail.com>
28b904f to
e72c8bb
Compare
|
Feedback addressed. Added cd - to the dataset configuration script to ensure users are returned to the repository root before executing the benchmark. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
RoboDK Palletizingexample previously contained hardcoded absolute paths tied to the original author's local environment (/root/ianvs/project/ianvs-0.3.0/examples/Palletizing/...). Furthermore, the directory name was incorrectly referenced asPalletizinginstead ofRoboDK Palletizing. This caused immediate failures for any new user attempting to run the benchmark.Changes implemented:
benchmarkingjob.yaml,testenv.yaml, andalgorithm.yamlto utilize portable, root-relative paths (./examples/RoboDK Palletizing/...).Palletizingdirectory references in all configuration files to match the actual repository structure (RoboDK Palletizing).readme.mdexecution commands to run from the repository root, ensuring the relative paths resolve correctly. Theianvs -fcommand is now properly quoted to handle the space in the directory name.readme.mdto map directly to the new expected relative path (./examples/RoboDK Palletizing/singletask_learning_bench/dataset/RoboDK_Palletizing_Dataset/).Which issue(s) this PR fixes:
This is a proactive fix for an unreported bug discovered during repository-wide path auditing.