Skip to content

fix: replace hardcoded absolute paths with root-relative paths in RoboDK Palletizing example#543

Open
Fahmid-Arman wants to merge 1 commit into
kubeedge:mainfrom
Fahmid-Arman:fix-robodk-paths
Open

fix: replace hardcoded absolute paths with root-relative paths in RoboDK Palletizing example#543
Fahmid-Arman wants to merge 1 commit into
kubeedge:mainfrom
Fahmid-Arman:fix-robodk-paths

Conversation

@Fahmid-Arman

Copy link
Copy Markdown

What type of PR is this?
/kind bug

What this PR does / why we need it:
The RoboDK Palletizing example previously contained hardcoded absolute paths tied to the original author's local environment (/root/ianvs/project/ianvs-0.3.0/examples/Palletizing/...). Furthermore, the directory name was incorrectly referenced as Palletizing instead of RoboDK Palletizing. This caused immediate failures for any new user attempting to run the benchmark.

Changes implemented:

  • Configuration Remediation: Updated benchmarkingjob.yaml, testenv.yaml, and algorithm.yaml to utilize portable, root-relative paths (./examples/RoboDK Palletizing/...).
  • Directory Name Correction: Fixed the incorrect Palletizing directory references in all configuration files to match the actual repository structure (RoboDK Palletizing).
  • Documentation Overhaul: Updated the readme.md execution commands to run from the repository root, ensuring the relative paths resolve correctly. The ianvs -f command is now properly quoted to handle the space in the directory name.
  • Dataset Path Alignment: Updated the dataset download instructions in readme.md to map directly to the new expected relative path (./examples/RoboDK Palletizing/singletask_learning_bench/dataset/RoboDK_Palletizing_Dataset/).

Which issue(s) this PR fixes:
This is a proactive fix for an unreported bug discovered during repository-wide path auditing.

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 13, 2026
@kubeedge-bot kubeedge-bot requested review from Poorunga and hsj576 June 13, 2026 16:22
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fahmid-Arman
To complete the pull request process, please assign jaypume after the PR has been reviewed.
You can assign the PR to them by writing /assign @jaypume in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the RoboDK Palletizing single-task learning benchmark example by replacing absolute paths with relative paths, making the configuration self-contained and runnable from the repository root. It also updates the README instructions for downloading and unzipping the dataset. The feedback suggests adding a cd - command to the dataset setup script in the README to return the user to the repository root, ensuring the subsequent benchmarking command runs seamlessly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread examples/RoboDK Palletizing/singletask_learning_bench/readme.md
@Fahmid-Arman

Copy link
Copy Markdown
Author

/assign @jaypume

…oDK Palletizing example

Signed-off-by: Fahmid Arman <fahmid.brac@gmail.com>
@Fahmid-Arman

Copy link
Copy Markdown
Author

Feedback addressed. Added cd - to the dataset configuration script to ensure users are returned to the repository root before executing the benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants