fix(aoa/TForest) : add requirements.txt and harden hardcoded paths in tools.py#546
fix(aoa/TForest) : add requirements.txt and harden hardcoded paths in tools.py#546SurbhiD404 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SurbhiD404 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request adds a requirements.txt file for the TForest benchmark and refactors path resolution in tools.py to use pathlib.Path relative to the file's base directory. Feedback suggests improving the robustness of load_test by resolving any relative path argument relative to BASE_DIR as well.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
89e222a to
52a6139
Compare
…n tools.py Signed-off-by: Surbhi Dharvan <dharvansurbhi@gmail.com>
52a6139 to
86e1e16
Compare
Summary
Fixes the dependency and path-handling issues reported in #323 for the TForest example.
Changes
Add
requirements.txtcontaining the runtime dependencies required by the TForest example:numpyjoblibmatplotlibstatsmodelsscienceplotsscikit-learntqdmpandasReplace hardcoded relative paths in
tools.pywithpathlib-based paths resolved relative to the script location.Issue Reproduction
On a clean environment, running the TForest example fails immediately with:
In addition,
tools.pyrelied on relative paths that depend on the current working directory, making execution fragile when launched from different locations.Validation
Installed dependencies using:
Verified imports:
python -c "import numpy, joblib, matplotlib, statsmodels, scienceplots, sklearn, tqdm, pandas; print('All imports OK')"Output:
After installing dependencies, execution proceeds beyond the original import failure and reaches the next stage of the workflow.
Fixes #323