fix: migrate legacy Sedna API calls to standard inference methods in lifelong learning#553
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fahmid-Arman The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the lifelong learning algorithm to use the standard inference method instead of custom variants. The review feedback correctly identifies that job.inference returns a 3-tuple, and assigning it directly to test_res will cause a type mismatch downstream; it suggests unpacking the tuple to only assign the first element.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…lifelong learning Signed-off-by: Fahmid Arman <fahmid.brac@gmail.com>
8024cf0 to
98ed644
Compare
|
/assign @MooreZheng |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The lifelong learning paradigm controller previously called
job.my_inference()andjob.inference_2(), which are internal Sedna fork methods absent from the public Sedna 0.6.0.1 API. These raisedAttributeErrors that blocked test inference from executing.job.my_inference()andjob.inference_2()calls with the standardjob.inference()method.LifelongLearningAPI contract.no-inferenceand hard-example mining modes.Which issue(s) this PR fixes:
Fixes #461