Skip to content

fix: migrate legacy Sedna API calls to standard inference methods in lifelong learning#553

Open
Fahmid-Arman wants to merge 1 commit into
kubeedge:mainfrom
Fahmid-Arman:fix-issue-461-lifelong-inference-api
Open

fix: migrate legacy Sedna API calls to standard inference methods in lifelong learning#553
Fahmid-Arman wants to merge 1 commit into
kubeedge:mainfrom
Fahmid-Arman:fix-issue-461-lifelong-inference-api

Conversation

@Fahmid-Arman

Copy link
Copy Markdown

What type of PR is this?
/kind bug

What this PR does / why we need it:
The lifelong learning paradigm controller previously called job.my_inference() and job.inference_2(), which are internal Sedna fork methods absent from the public Sedna 0.6.0.1 API. These raised AttributeErrors that blocked test inference from executing.

  • Replaced the deprecated job.my_inference() and job.inference_2() calls with the standard job.inference() method.
  • Aligned the core Ianvs framework with the public Sedna LifelongLearning API contract.
  • Unblocked the final test inference step for all lifelong learning examples running in no-inference and hard-example mining modes.

Which issue(s) this PR fixes:
Fixes #461

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 15, 2026
@kubeedge-bot kubeedge-bot requested review from Poorunga and hsj576 June 15, 2026 21:44
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fahmid-Arman
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the lifelong learning algorithm to use the standard inference method instead of custom variants. The review feedback correctly identifies that job.inference returns a 3-tuple, and assigning it directly to test_res will cause a type mismatch downstream; it suggests unpacking the tuple to only assign the first element.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread core/testcasecontroller/algorithm/paradigm/lifelong_learning/lifelong_learning.py Outdated
…lifelong learning

Signed-off-by: Fahmid Arman <fahmid.brac@gmail.com>
@Fahmid-Arman Fahmid-Arman force-pushed the fix-issue-461-lifelong-inference-api branch from 8024cf0 to 98ed644 Compare June 15, 2026 21:46
@Fahmid-Arman

Copy link
Copy Markdown
Author

/assign @MooreZheng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Core Framework][no-inference] AttributeError: 'LifelongLearning' object has no attribute 'my_inference'

3 participants