Fix rank picture mode without matrix#560
Conversation
Signed-off-by: Avinash Kumar Deepak <avinash8655279@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: avinxshKD The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request adds a safety check in core/storymanager/rank/rank.py to verify if the matrix object is valid before attempting to iterate over its keys, preventing potential errors. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
pls take a look, minimal fix @MooreZheng @hsj576 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
selected_and_all_and_picturecurrently assumes every result has aMatrixmetric.For normal benchmarks with scalar metrics only,
_draw_pictures()getsNoneand crashes onmatrix.keys(), even though the rank CSV files can be saved.Which issue(s) this PR fixes:
Fixes #559