Skip to content

Fix rank picture mode without matrix#560

Open
avinxshKD wants to merge 1 commit into
kubeedge:mainfrom
avinxshKD:fix/rank-picture-missing-matrix
Open

Fix rank picture mode without matrix#560
avinxshKD wants to merge 1 commit into
kubeedge:mainfrom
avinxshKD:fix/rank-picture-missing-matrix

Conversation

@avinxshKD

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

selected_and_all_and_picture currently assumes every result has a Matrix metric.

For normal benchmarks with scalar metrics only, _draw_pictures() gets None and crashes on matrix.keys(), even though the rank CSV files can be saved.

Which issue(s) this PR fixes:

Fixes #559

Signed-off-by: Avinash Kumar Deepak <avinash8655279@gmail.com>
@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 20, 2026
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avinxshKD
To complete the pull request process, please assign jaypume after the PR has been reviewed.
You can assign the PR to them by writing /assign @jaypume in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a safety check in core/storymanager/rank/rank.py to verify if the matrix object is valid before attempting to iterate over its keys, preventing potential errors. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@avinxshKD

Copy link
Copy Markdown
Author

pls take a look, minimal fix @MooreZheng @hsj576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rank: selected_and_all_and_picture crashes when Matrix metric is missing

2 participants