fix(pipelines-components): improve title casing in AutoML and AutoRAG component README's - #196
Open
mateusz-szewczyk-dev wants to merge 1 commit into
Open
mateusz-szewczyk-dev wants to merge 1 commit into
mateusz-szewczyk-dev wants to merge 1 commit into
Conversation
…text Signed-off-by: Mateusz Szewczyk <mszewczy@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Summary
format_title()with aSPECIAL_CASE_WORDSmapping inconstants.py, adding support forAutoMLandAutoRAGalongside the existingKFP,API,URL,ID,UI,CI,CDcases.wrap_text()fromcontent_generator.pytoutils.pyand removed the leftover duplicate definition that remained incontent_generator.pyafter the move; it now importswrap_text()fromutils.pyalongsideformat_title().yoda_data_processor/component.pyand unwrapped a warning message onto a single line invalidate_examples.py.Why
wrap_text()is a general text-formatting helper, not README-content-generation logic, so it belongs inutils.pyalongsideformat_title()rather than incontent_generator.py. Completing the move (removing the stray duplicate) keeps a single source of truth. Moving the special-case word list toconstants.pyalso makes it easier to extend without touching function logic.Checklist:
Pre-Submission Checklist
Learn more about the pull request title convention used in this repository.
Additional Checklist Items for New or Updated Components/Pipelines
metadata.yamlincludes freshlastVerifiedtimestampare present and complete
snake_casenaming convention