Add skip authz namespace option#380
Open
FabianKramm wants to merge 1 commit into
Open
Conversation
Signed-off-by: Fabian Kramm <fab.kramm@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a use case where we don't want the namespace added to the azure scope and request path as this allows us to validate request against resource groups directly (and potentially other resources).
However, since guard always adds this information currently, we end up with authz requests being denied for namespace based requests while its working for cluster-scoped requests. This PR adds a new option
azure.skip-authz-namespaceto disable adding the namespace.Would be great if this could get merged eventually, I'm also happy to maintain a fork on our side with this change, but I believe this might be useful for others as well. I also added a unit test, if there is anything else I should change / add just let me know.