Fix why SVG/DOT subgraph pruning#103
Merged
Merged
Conversation
k8s-ci-robot
added
the
needs-rebase
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/L
For SVG/DOT output, compute the path subgraph directly in O(V+E) using bidirectional BFS reachability instead of enumerating individual paths via DFS (which is exponentially slow on dense transitive graphs). This fixes `depstat why go.opentelemetry.io/otel --svg` hanging for 16-38+ minutes on Kubernetes, etcd, and containerd — now completes in under 1 second. Key changes: - Add computeReachableToTarget() for backward BFS pruning - Add computePathSubgraph() for O(V+E) node/edge set extraction - SVG/DOT renderers use pre-computed NodeSet/EdgeSet when available - Add --max-depth flag for DFS depth limiting on text/JSON output - Add safety iteration cap in assignLayers() for defense-in-depth - Filter cycle back-edges using BFS depth ordering to ensure DAG Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
fix-why-svg-otel-timeout
branch
from
5169435 to
45eb8b4
Compare
k8s-ci-robot
removed
the
needs-rebase
dims
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing