Skip to content

capi: isolate Azure CI CLI auth per SIG build - #2086

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:mainfrom
MaxRink:tcaas/azure-ci-isolate-cli-config
Jul 3, 2026
Merged

capi: isolate Azure CI CLI auth per SIG build#2086
kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:mainfrom
MaxRink:tcaas/azure-ci-isolate-cli-config

Conversation

@MaxRink

@MaxRink MaxRink commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

What this does

The Azure SIG presubmit starts many SIG builds in the background. Today all children share the same Azure CLI config directory while Packer is using Azure CLI auth, which can leave a child without a visible default subscription.

This gives each background SIG build its own AZURE_CONFIG_DIR, logs in inside that child, and keeps the selected Azure location scoped to that child. The parent still logs in once for shared setup such as Flatcar version discovery and cleanup.

Why

This addresses an Azure SIG CI race observed while maintaining the open image-builder PR train. A target failed immediately after init-sig.sh had successfully created the resource group/gallery:

error fetching tenantID and subscriptionID from Azure CLI (are you logged on using `az login`?): Unable to find default subscription

The same target succeeded in another PR, which points at a CI auth race rather than a target-specific build regression.

Validation

  • bash -n images/capi/scripts/ci-azure-e2e.sh
  • git diff --check
  • shellcheck images/capi/scripts/ci-azure-e2e.sh still reports pre-existing findings from main; the unquoted array expansion errors and the changed wait PID handling are fixed by this PR.
  • NO_COLOR=1 make lint fails locally on unrelated pre-existing Ansible var-naming[no-role-prefix] violations under images/capi/ansible/; no changed shell-script syntax failure was reported.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2026
@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 28, 2026
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2026
@MaxRink
MaxRink force-pushed the tcaas/azure-ci-isolate-cli-config branch 2 times, most recently from 91fba2a to 8382607 Compare July 1, 2026 17:58
@MaxRink
MaxRink marked this pull request as ready for review July 3, 2026 11:08
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from jsturtevant July 3, 2026 11:08
@MaxRink
MaxRink force-pushed the tcaas/azure-ci-isolate-cli-config branch from 08d47f5 to 0e22fc7 Compare July 3, 2026 11:15

@mboersma mboersma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 1f4a492 into kubernetes-sigs:main Jul 3, 2026
7 checks passed
vomba pushed a commit to elastisys/image-builder that referenced this pull request Jul 14, 2026
…solate-cli-config

capi: isolate Azure CI CLI auth per SIG build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants