capi: retry upstream artifact downloads - #2138
Merged
kubernetes-prow[bot] merged 1 commit intoAug 17, 2026
Merged
Conversation
kubernetes-prow
Bot
added
cncf-cla: yes
The build fetches release artifacts from github.com and
storage.googleapis.com. One read timeout stops the whole packer build.
TASK [kubernetes : Download crictl]
fatal: [default]: FAILED! => {"msg": "Connection failure: The read
operation timed out", "url": ".../crictl-v1.36.0-linux-amd64.tar.gz.sha256"}
This commit adds a retry loop to the get_url tasks in the node build path.
Three tasks already set retries without until. Ansible sets retries to 1
when until is absent, so those retries never run. This commit adds until
to them.
The downloads keep their checksum. A retry cannot hide a corrupt artifact.
MaxRink
force-pushed
the
capi/retry-upstream-artifact-downloads
branch
from
August 14, 2026 17:50
caeef96 to
732a241
Compare
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The build fetches release artifacts from github.com and storage.googleapis.com. One read timeout stops the whole packer build. Unrelated pull requests then show a red check.
Example from a recent
pull-azure-sigsrun:This change adds a retry loop to the
get_urltasks in the node build path:Three tasks already set
retrieswithoutuntil. Ansible setsretriesto 1 whenuntilis absent, so those retries never run. This change addsuntilto them:The retry pattern matches the one for apt lock contention in
roles/kubernetes/tasks/debian.yml.The downloads keep their checksum. A retry cannot hide a corrupt artifact.
How this was verified
ansible-lintreports 0 failures on the changed files.Which issue(s) this PR fixes
The failure appears on #2072, #2080, #2087 and #2098. None of these pull requests change the download tasks.
Release note