fix: bump kubeadm config API from v1beta3 to v1beta4 - #2154
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @cleman95! |
|
Hi @cleman95. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4556344 to
72f194a
Compare
The kubeadm.k8s.io/v1beta3 API was removed in kubeadm 1.36, causing build failures for Kubernetes 1.36+ with the error: error: your configuration file uses an old API spec: "kubeadm.k8s.io/v1beta3" v1beta4 has been available since kubeadm 1.29, so all currently supported Kubernetes versions accept it.
72f194a to
8aadd0f
Compare
|
Duplicate of #2152 |
|
Hey @cleman95 I've been working through and looks like we already have a PR in for this. To prevent duplicates, we'll close this one and move the other forward. |
|
Sure, sorry I haven't checked if another PR was opened ! Thanks for linking the PR to my issue |
What this PR does
Bumps the kubeadm config template API version from
v1beta3tov1beta4.The
kubeadm.k8s.io/v1beta3API was removed in kubeadm 1.36, causing image builds for Kubernetes 1.36+ to fail with:v1beta4has been available since kubeadm 1.29, so all currently supported Kubernetes versions (1.29–1.37) accept it. The fields used in the template are unchanged between v1beta3 and v1beta4.Which issue(s) this PR fixes
Fixes #2151
Fixes #2153
Special notes for your reviewer
This is a two-line change that only bumps the
apiVersionfield in the kubeadm config template. No schema changes are needed for the fields currently in use.