Skip to content

Thread the reconcile context into the spoke client calls - #75

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
magic-peach:fix/thread-context-apply-controller
Sep 4, 2026
Merged

Thread the reconcile context into the spoke client calls#75
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
magic-peach:fix/thread-context-apply-controller

Conversation

@magic-peach

Copy link
Copy Markdown
Contributor

applyManifests and applyUnstructrued built their Get/Create/Update calls against the spoke cluster off context.TODO() instead of the context Reconcile already receives, so a cancellation or deadline set by the manager never reached those calls.

This threads ctx from Reconcile through applyManifests into applyUnstructrued and uses it for all three spoke client calls, replacing the three context.TODO() calls. No other file references either function, so the signature change is self contained, and it does not touch any API type.

Tested: make test passes, including the envtest backed controller suite (72.2% coverage on pkg/controllers), same as it does on unmodified master.

/kind bug
/sig multicluster

applyManifests and applyUnstructrued built their Get/Create/Update
calls against the spoke cluster off context.TODO() instead of the
context Reconcile already receives, so a cancellation or deadline set
by the manager never reached those calls.
@kubernetes-prow kubernetes-prow Bot added kind/bug Categorizes issue or PR as related to a bug. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. labels Sep 4, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from qiujian16 and skitt September 4, 2026 03:35
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @magic-peach!

It looks like this is your first PR to kubernetes-sigs/work-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/work-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2026
@skitt

skitt commented Sep 4, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

Thanks!

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: magic-peach, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 8e2a94d into kubernetes-sigs:master Sep 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants