Thread the reconcile context into the spoke client calls - #75
Conversation
applyManifests and applyUnstructrued built their Get/Create/Update calls against the spoke cluster off context.TODO() instead of the context Reconcile already receives, so a cancellation or deadline set by the manager never reached those calls.
|
Welcome @magic-peach! |
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: magic-peach, skitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
applyManifests and applyUnstructrued built their Get/Create/Update calls against the spoke cluster off context.TODO() instead of the context Reconcile already receives, so a cancellation or deadline set by the manager never reached those calls.
This threads ctx from Reconcile through applyManifests into applyUnstructrued and uses it for all three spoke client calls, replacing the three context.TODO() calls. No other file references either function, so the signature change is self contained, and it does not touch any API type.
Tested: make test passes, including the envtest backed controller suite (72.2% coverage on pkg/controllers), same as it does on unmodified master.
/kind bug
/sig multicluster