Migrate google/btree usage to k8s util package#135793
Migrate google/btree usage to k8s util package#135793pjsharath28 wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
Please note that we're already in Code Freeze for the upcoming v1.35.0 release. Adding the milestone to this PR is strictly prohibited without proper approval. If this PR needs to be included in the v1.35.0 release:
We're also in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Dec 17 09:50:12 UTC 2025. |
|
Hi @pjsharath28. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pjsharath28 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
based on the linked discussion I think @dims referred to https://github.com/kubernetes/utils |
|
Sure, thanks for the clarification @aojea I have raised the PR in utils repo kubernetes/utils#336 for the same and hence closing this PR. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The
github.com/google/btreelibrary used by k8s and etcd has been archived and is no longer maintained. This raises long-term concerns around security fixes and CVEs.We discussed multiple options to address this in the issue. Given that we only rely on a single source file from the library, we concluded that copying the code into
k8s.io/utilsis the simplest option. This avoids introducing or maintaining a separate fork while preserving identical behaviour.Which issue(s) this PR is related to:
Discussion issue: etcd-io/etcd#20991
Special notes for your reviewer:
Upstream Google attribution is preserved and the file header follows Kubernetes conventions while remaining Apache-2.0 compliant.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: