fix(webhook): reject cluster deletion when ListResources fails (#371)#375
Open
Elvand-Lie wants to merge 1 commit into
Open
fix(webhook): reject cluster deletion when ListResources fails (#371)#375Elvand-Lie wants to merge 1 commit into
Elvand-Lie wants to merge 1 commit into
Conversation
…lice#371) Signed-off-by: Elvand-Lie <elvandlie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validateClusterInAnySliceinservice/cluster_webhook_validation.go(lines 81-106) validates whether a cluster can be safely deleted by checking if it participates in any slice. The function callsutil.ListResourcesat line 84, but both downstream conditionals (lines 98, 102) only execute whenerr == nil. If the API call fails, control falls through both checks and returnsnil- allowing the deletion to proceed despite being unable to verify slice participation.Changes:
service/cluster_webhook_validation.go: Add early return withfield.InternalErrorwhenListResourcesfails, following the fail-closed principle for safety-critical validationerr == nilguards from both conditionals sinceerris guaranteednilafter the early returnFixes #371
How Has This Been Tested?
go build ./...passesChecklist:
Does this PR introduce a breaking change for other components like worker-operator?
No. This only affects the cluster delete validation webhook. The behavioral change is that cluster deletion is now correctly rejected (fail-closed) during API server instability, instead of being silently allowed.