improvement(util): wrap Retry last error with %w for error chain pres…#381
Open
mdryaan wants to merge 1 commit into
Open
improvement(util): wrap Retry last error with %w for error chain pres…#381mdryaan wants to merge 1 commit into
mdryaan wants to merge 1 commit into
Conversation
…ervation Signed-off-by: mdryaan <alikhurshid4u@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
util.Retryinutil/common.go(line 220) used%sas the verb when wrapping the last error in the finalfmt.Errorfcall. This converts the error to a plain string, permanently discarding its type. Any caller usingerrors.Isorerrors.Ason autil.Retryreturn value would always getfalse, making it impossible to inspect or match the underlying cause. Changing%sto%wmakes the error chain available to callers without any behaviour change at runtime.Fixes #380
How Has This Been Tested?
util/common.goline 220 changed from%sto%w.go build ./...passes. The pre-existingmake vetandmake unit-testfailures (undefined: util.Client,unknown field ClusterName) exist on master before this branch and are unrelated to this change.Checklist: