improvement(worker-slice-config): emit update-failed event and metric in ReconcileWorkerSliceConfig#383
Open
mdryaan wants to merge 1 commit into
Conversation
… in ReconcileWorkerSliceConfig Signed-off-by: mdryaan <alikhurshid4u@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ReconcileWorkerSliceConfiginservice/worker_slice_config_service.go(lines 282–286) calledutil.UpdateResourceand returned the error silently on failure — no Kubernetes Event and no Prometheus metric were recorded. The identical failure path inCreateMinimalWorkerSliceConfig(lines 397–414 of the same file)correctly records
EventWorkerSliceConfigUpdateFailedand increments theKubeSliceEventsCountermetric. BotheventRecorderands.mfwere already in scope at the failure site. Added the missingutil.RecordEventands.mf.RecordCounterMetriccalls to match the established pattern, making update failures visible inkubectl get eventsand Prometheus dashboards.Fixes #382
How Has This Been Tested?
service/worker_slice_config_service.golines 283–284: insertedutil.RecordEvent(ctx, eventRecorder, workerSliceConfig, nil, events.EventWorkerSliceConfigUpdateFailed)ands.mf.RecordCounterMetric(...)before the return, copying the exact pattern from lines 399–408 in the same file.go build ./...passes. Pre-existingmake vetfailure (undefined: util.Clientinaccess_control_service_test.go) exists on master before thisbranch and is unrelated to this change.
Checklist:
Does this PR introduce a breaking change for other components like worker-operator?
No