improvement(service): replace duplicate checkForProjectNamespace methods with util.CheckForProjectNamespace#385
Open
mdryaan wants to merge 1 commit into
Conversation
duplicate checkForProjectNamespace methods with util.CheckForProjectNamespace Signed-off-by: mdryaan <alikhurshid4u@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three service structs (
ClusterService,SliceConfigService,SliceQoSConfigService) each defined a privatecheckForProjectNamespace(*corev1.Namespace) boolmethod with an identical body. The same check already exists as the publicutil.CheckForProjectNamespaceinutil/reconciliation_utility.go. All three private methods were removed and their single call sites updated to callutil.CheckForProjectNamespacedirectly. Thefmtimport inslice_qos_config_service.gowas also removed as it was only used by the deleted method. Net change: −19 lines, no behaviour change.Fixes #384
How Has This Been Tested?
Removed
checkForProjectNamespacefromcluster_service.go:337–339,slice_config_service.go:245–247, andslice_qos_config_service.go:127–129. Updated call sites atcluster_service.go:75,slice_config_service.go:131, andslice_qos_config_service.go:113to callutil.CheckForProjectNamespace. Removed unusedfmtimport fromslice_qos_config_service.go.go build ./...passes. Pre-existingmake vetfailure (undefined: util.Clientinaccess_control_service_test.go) exists on master before this branch and is unrelated to this change.Checklist:
Does this PR introduce a breaking change for other components like worker-operator?
No