fix(slice-qos-config): use correct QoSConfig event constants in DeleteSliceQoSConfig metrics#402
Open
mdryaan wants to merge 1 commit into
Open
Conversation
…eSliceQoSConfig metrics Signed-off-by: mdryaan <alikhurshid4u@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DeleteSliceQoSConfiginservice/slice_qos_config_service.gowas recording Prometheus counters withevents.EventSliceConfigDeletionFailed(line 178) andevents.EventSliceConfigDeleted(line 190) the SliceConfig constants instead of the QoSConfig-specificevents.EventSliceQoSConfigDeletionFailedandevents.EventSliceQoSConfigDeleted. Theutil.RecordEventcalls on the same lines already used the correct QoSConfig constants; only the metric counter labels were wrong. This caused all SliceQoSConfig deletion events to be counted under SliceConfig metric labels, making QoSConfig deletions invisible in QoS-specific dashboards and alerts.Fixes #401
How Has This Been Tested?
service/slice_qos_config_service.go:178changed fromevents.EventSliceConfigDeletionFailedtoevents.EventSliceQoSConfigDeletionFailed; line 190 changed fromevents.EventSliceConfigDeletedtoevents.EventSliceQoSConfigDeleted. Verified by diffing against master.go build ./...passes.make fmtpasses with no diff.make vetandmake unit-testfailures are present on unmodified master and are unrelated to this change.Checklist:
Does this PR introduce a breaking change for other components like worker-operator?
No