Skip to content

fix: return nil explicitly in SliceGateway NONET early-exit path #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdryaan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: return nil explicitly in SliceGateway NONET early-exit path #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/slicegateway/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func (r *SliceGwReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
if slice.Status.SliceConfig != nil &&
slice.Status.SliceConfig.SliceOverlayNetworkDeploymentMode == v1alpha1.NONET {
log.Info("No communication slice. Skipping slicegw reconcilation")
return ctrl.Result{}, err
return ctrl.Result{}, nil
}

// Check if slice router network service endpoint (NSE) is present before spawning slice gateway pod.
Expand Down