Skip to content

MTV-6062: replacing the problematic olm_level with controller_log_level - #953

Open
anarnold97 wants to merge 3 commits into
kubev2v:mainfrom
anarnold97:MTV-6062-olm-managed
Open

MTV-6062: replacing the problematic olm_level with controller_log_level#953
anarnold97 wants to merge 3 commits into
kubev2v:mainfrom
anarnold97:MTV-6062-olm-managed

Conversation

@anarnold97

@anarnold97 anarnold97 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

JIRA


Description

we have an old documentation bug (5y) in:
https://github.com/kubev2v/forklift-documentation/blob/main/documentation/modules/proc_installing-mtv-operator.adoc?plain=1#L124

where we give a wrong example yaml:

apiVersion: [forklift.konveyor.io/v1beta1](http://forklift.konveyor.io/v1beta1)
kind: ForkliftController
metadata:
  name: forklift-controller
  namespace: {namespace}
spec:
  olm_managed: true

A better example to use can be found in our code docs:
https://github.com/kubev2v/forklift/blob/main/docs/compatibility/forkliftcontroller-settings.md?plain=1#L16
for this specific fix, I suggest a simple example:

kind: ForkliftController
metadata:
  name: forklift-controller
  namespace: openshift-mtv
spec:
  controller_log_level: 3

replacing the problematic olm_level with controller_log_level that can do little harm, and it's default value is 3, so we don't change any settings by this example.


PREVIEW

@anarnold97
anarnold97 requested a review from RichardHoch July 8, 2026 09:59
@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
forklift-documentation Ready Ready Preview, Comment Jul 8, 2026 10:50am

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@anarnold97, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6f637a90-d060-47c8-8783-6652c88a6e6f

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7b28d and 3b13be7.

📒 Files selected for processing (1)
  • documentation/modules/proc_installing-mtv-operator.adoc
📝 Walkthrough

Walkthrough

This PR updates the installation documentation for the MTV operator. It restructures the AsciiDoc abstract block conditional logic for web/CLI sections and replaces the example ForkliftController YAML manifest with one using a fixed namespace and a new controller_log_level field.

Changes

Documentation Updates

Layer / File(s) Summary
Abstract structure and manifest example
documentation/modules/proc_installing-mtv-operator.adoc
Adds an _abstract role block wrapping the web/CLI conditional intro headings, and replaces the ForkliftController example YAML by removing apiVersion/olm_managed/{namespace} and adding a fixed openshift-mtv namespace with spec.controller_log_level: 3.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title captures the main documentation change: replacing the example's old managed setting with controller_log_level.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@documentation/modules/proc_installing-mtv-operator.adoc`:
- Around line 125-130: Restore the missing apiVersion in the example manifest so
the ForkliftController YAML is a valid resource for oc apply; update the
manifest example under the ForkliftController block with the correct apiVersion
while keeping the existing kind, metadata name forklift-controller, namespace
openshift-mtv, and spec controller_log_level fields intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce1ef4cd-6433-40a0-a1d0-84bb8d543c8d

📥 Commits

Reviewing files that changed from the base of the PR and between 9306bc2 and 6f7b28d.

📒 Files selected for processing (1)
  • documentation/modules/proc_installing-mtv-operator.adoc

Comment thread documentation/modules/proc_installing-mtv-operator.adoc Outdated
@yaacov

yaacov commented Jul 8, 2026

Copy link
Copy Markdown
Member

lgtm,

@solenoci suggested:

apiVersion: forklift.konveyor.io/v1beta1
kind: ForkliftController
metadata: 
  name: forklift-controller
  namespace: openshift-mtv
spec":
  feature_ui_plugin: true
  feature_validation: true
  feature_volume_populator: true

so, good as it, can be better with nicer fields similar to our code-docs in:
https://github.com/kubev2v/forklift/blob/main/docs/compatibility/forkliftcontroller-settings.md?plain=1#L16

Signed-off-by: A.Arnold <anarnold@redhat.com>
Comment thread documentation/modules/proc_installing-mtv-operator.adoc
Comment thread documentation/modules/proc_installing-mtv-operator.adoc Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants