MTV-6062: replacing the problematic olm_level with controller_log_level - #953
MTV-6062: replacing the problematic olm_level with controller_log_level#953anarnold97 wants to merge 3 commits into
Conversation
Signed-off-by: A.Arnold <anarnold@redhat.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the installation documentation for the MTV operator. It restructures the AsciiDoc abstract block conditional logic for web/CLI sections and replaces the example ForkliftController YAML manifest with one using a fixed namespace and a new controller_log_level field. ChangesDocumentation Updates
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@documentation/modules/proc_installing-mtv-operator.adoc`:
- Around line 125-130: Restore the missing apiVersion in the example manifest so
the ForkliftController YAML is a valid resource for oc apply; update the
manifest example under the ForkliftController block with the correct apiVersion
while keeping the existing kind, metadata name forklift-controller, namespace
openshift-mtv, and spec controller_log_level fields intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ce1ef4cd-6433-40a0-a1d0-84bb8d543c8d
📒 Files selected for processing (1)
documentation/modules/proc_installing-mtv-operator.adoc
|
lgtm, @solenoci suggested: so, good as it, can be better with nicer fields similar to our code-docs in: |
Signed-off-by: A.Arnold <anarnold@redhat.com>
JIRA
Description
we have an old documentation bug (5y) in:
https://github.com/kubev2v/forklift-documentation/blob/main/documentation/modules/proc_installing-mtv-operator.adoc?plain=1#L124
where we give a wrong example yaml:
A better example to use can be found in our code docs:
https://github.com/kubev2v/forklift/blob/main/docs/compatibility/forkliftcontroller-settings.md?plain=1#L16
for this specific fix, I suggest a simple example:
replacing the problematic olm_level with controller_log_level that can do little harm, and it's default value is 3, so we don't change any settings by this example.
PREVIEW