Feat: add an example about the global-variables policy#95
Draft
barnettZQG wants to merge 1 commit into
Draft
Conversation
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
barnettZQG
changed the title
wonderflow
reviewed
Jul 21, 2022
| port: context.variables.DB_PORT | ||
| user: context.variables.DB_USER | ||
| password: context.variables.DB_PASSWORD | ||
| database: context.variables.DB_DATABASE |
Contributor
There was a problem hiding this comment.
这个方案的核心问题是会把我们从 IaD 变成 IaC。 每个 value 都加入了 magic，需要计算一下，再render。
现在我们的 Application 是 IaD 的，每个数据都是固定的 data，不需要计算。 唯一需要计算的可能就是 output 里加入了一个 valueFrom
Contributor
Author
There was a problem hiding this comment.
如果要保留之前的机制，那就是通过 valueFrom 来设置参数获取和赋值。但是感觉写起来有点多余。因为不得不为 每个字段先写一个默认值。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: barnettZQG barnett.zqg@gmail.com