Test branch#394
Conversation
Signed-off-by: Pushparaj Shetty K S <pshettyks@guidewire.com>
Signed-off-by: Pushparaj Shetty K S <pshettyks@guidewire.com>
Signed-off-by: Pushparaj Shetty K S <pshettyks@guidewire.com>
Signed-off-by: Pushparaj Shetty K S <pshettyks@guidewire.com>
Signed-off-by: Pushparaj Shetty K S <pshettyks@guidewire.com>
Signed-off-by: Pushparaj Shetty K S <pshettyks@guidewire.com>
Signed-off-by: Pushparaj Shetty K S <pshettyks@guidewire.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 9 issues across 17 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
|
|
||
| env: | ||
| GO_VERSION: '1.17.6' | ||
| GO_VERSION: '1.23.8' |
There was a problem hiding this comment.
Go 1.23.8 is not a released version as of June 2024; the latest stable release is 1.22.x. Using a non-existent Go version will cause the workflow to fail during setup-go.
| GO_VERSION: '1.23.8' | |
| GO_VERSION: '1.22.4' |
| module backup_restore | ||
|
|
||
| go 1.17 | ||
| go 1.23.8 |
There was a problem hiding this comment.
Go version 1.23.8 is not released as of June 2024; the latest stable Go version is 1.22.x. Using a non-existent Go version will break builds and tooling.
| go 1.23.8 | |
| go 1.22.4 |
| @{ \ | ||
| set -e ;\ | ||
| GO111MODULE=off go get -u golang.org/x/tools/cmd/goimports ;\ | ||
| go install golang.org/x/tools/cmd/goimports@latest ;\ |
There was a problem hiding this comment.
Using 'go install ...@latest' for goimports can introduce non-determinism, as the installed version may change over time. Pin to a specific version for reproducible builds.
| go install golang.org/x/tools/cmd/goimports@latest ;\ | |
| go install golang.org/x/tools/cmd/goimports@v0.12.0 ;\ |
|
|
||
| # Produce CRDs that work back to Kubernetes 1.11 (no version conversion) | ||
| CRD_OPTIONS ?= "crd:trivialVersions=true" | ||
| CRD_OPTIONS ?= "crd" |
There was a problem hiding this comment.
Removing 'trivialVersions=true' from CRD_OPTIONS may cause CRDs to lack trivial version conversion, which can break compatibility with clusters running Kubernetes 1.11 or later that expect this field. Consider whether this is intentional and document the change if so.
| CRD_OPTIONS ?= "crd" | |
| CRD_OPTIONS ?= "crd:trivialVersions=true" |
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: 1.17 | ||
| go-version: 1.23 |
There was a problem hiding this comment.
Go 1.23 is not released as of June 2024. Using a non-existent Go version will cause the workflow to fail at setup. Use the latest available stable Go version instead.
| go-version: 1.23 | |
| go-version: 1.22 |
| @@ -1,5 +1,5 @@ | |||
| # Build the manager binary | |||
| FROM golang:1.17-alpine as builder | |||
| FROM golang:1.23-alpine as builder | |||
There was a problem hiding this comment.
Golang 1.23 is not released as of June 2024, so this base image will not be available and will cause build failures.
| FROM golang:1.23-alpine as builder | |
| FROM golang:1.22-alpine as builder |
| module github.com/oam-dev/terraform-controller | ||
|
|
||
| go 1.17 | ||
| go 1.23.8 |
There was a problem hiding this comment.
The go directive must use the format "go ."; including a patch version (".8") makes the module file invalid and will cause go tooling to fail to parse the file.
| go 1.23.8 | |
| go 1.23 |
| # the regex is used to ignore names within pkg. (default "fmt:.*"). | ||
| # see https://github.com/kisielk/errcheck#the-deprecated-method for details | ||
| ignore: fmt:.*,io/ioutil:^Read.* | ||
| exclude-functions: fmt:.*,io/ioutil:^Read.* |
There was a problem hiding this comment.
'exclude-functions' is not a valid key for errcheck linter settings; the correct key is 'ignore'. This will cause the linter to ignore this exclusion rule.
| exclude-functions: fmt:.*,io/ioutil:^Read.* | |
| ignore: fmt:.*,io/ioutil:^Read.* |
| output: | ||
| # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number" | ||
| format: colored-line-number | ||
| formats: colored-line-number |
There was a problem hiding this comment.
'formats' is not a valid key for output format in golangci-lint configuration; the correct key is 'format'. This will cause the linter to ignore the output format setting.
| formats: colored-line-number | |
| format: colored-line-number |
1 participant
Summary by cubic
Upgraded Go to 1.23.8, updated Kubernetes dependencies, and refreshed CRDs and CI workflows for compatibility and improved tooling.
Dependencies
CI and CRDs