cluster: Fix kubevirtci clone storm#98
Merged
kubevirt-bot merged 1 commit intokubevirt:mainfrom Mar 23, 2026
Merged
Conversation
kubevirt-bot
added
release-note-none
Collaborator
Author
|
cc @ormergi |
cluster::install checks whether the existing kubevirtci clone matches the requested one by comparing both the remote URL and the tag. The remote URL check fails when the clone was done via SSH (git@github.com:...) because the stored KUBEVIRTCI_REPO uses HTTPS (https://github.com/...). The mismatch causes kubevirtci to be deleted and re-cloned on every invocation, wiping the cluster kubeconfig and breaking the dev workflow. Remove the remote URL check and keep only the tag comparison. Drop the now-unused KUBEVIRTCI_REPO variable. Derived from: kubevirt/cluster-network-addons-operator#2619 Assisted-by: Cursor (claude-4.6-sonnet-medium-thinking) Signed-off-by: Or Shoval <oshoval@redhat.com>
Collaborator
Author
|
/retest |
|
/lgtm |
Collaborator
Author
|
Thanks Or @RamLavi can you please review ? |
|
Pull requests that are marked with After that period the bot marks them with the label /label needs-approver-review |
kubevirt-bot
added
the
needs-approver-review
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/remove-label needs-approver-review |
kubevirt-bot
removed
the
needs-approver-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
cluster::installchecks whether the existing kubevirtci clone matches the requested one by comparing both the remote URL and the tag.The remote URL check fails when the clone was done via SSH (
git@github.com:...) because the storedKUBEVIRTCI_REPOuses HTTPS (https://github.com/...).The mismatch causes kubevirtci to be deleted and re-cloned on every invocation, wiping the cluster kubeconfig and breaking the dev workflow.
Remove the remote URL check and keep only the tag comparison.
Derived from: kubevirt/cluster-network-addons-operator#2619
Special notes for your reviewer:
Release note: