Skip to content

Set GA running again.#758

Merged
jhkrug merged 5 commits into
kubewarden:mainfrom
jhkrug:re-add-gat
May 21, 2026
Merged

Set GA running again.#758
jhkrug merged 5 commits into
kubewarden:mainfrom
jhkrug:re-add-gat

Conversation

@jhkrug
Copy link
Copy Markdown
Contributor

@jhkrug jhkrug commented May 20, 2026

GA turned off for go-live. setting it running again.

Signed-off-by: John Krug <john.krug@suse.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 20, 2026

Deploy Preview for docs-kubewarden-io ready!

Name Link
🔨 Latest commit a3ef2aa
🔍 Latest deploy log https://app.netlify.com/projects/docs-kubewarden-io/deploys/6a0f0b06dd82fd000846a45d
😎 Deploy Preview https://deploy-preview-758--docs-kubewarden-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should disable GA somehow, when deploying in CI: https://github.com/kubewarden/docs/blob/main/netlify.toml#L5

@@ -26,5 +25,4 @@ href="https://fonts.googleapis.com/css2?family=SUSE:wght@100..800&display=swap"
<link rel="preconnect" href="https://www.google-analytics.com">
<link rel="preconnect" href="https://www.googletagmanager.com">
<script async="" src="https://www.googletagmanager.com/gtag/js?id=G-PSW07XK7TM"></script>
Copy link
Copy Markdown
Member

@viccuad viccuad May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to parametrize this GA id here, and add it into kw-remote-community-playbook.yml as a variable. Then, we can overwrite it somehow when building for netlify.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let me think.

jhkrug added 3 commits May 20, 2026 13:01
Signed-off-by: John Krug <john.krug@suse.com>
Signed-off-by: John Krug <john.krug@suse.com>
Signed-off-by: John Krug <john.krug@suse.com>
Copy link
Copy Markdown
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the effort!

Signed-off-by: John Krug <john.krug@suse.com>
@jhkrug jhkrug merged commit c6c1283 into kubewarden:main May 21, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Pending review to Done in Kubewarden Admission Controller May 21, 2026
@jhkrug jhkrug deleted the re-add-gat branch May 21, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants