docs: clarify workload owner kinds supported by WorkloadScan#1181
Open
fabriziosestito wants to merge 1 commit into
Open
docs: clarify workload owner kinds supported by WorkloadScan#1181fabriziosestito wants to merge 1 commit into
fabriziosestito wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
+ Coverage 53.41% 53.47% +0.05%
==========================================
Files 61 61
Lines 5328 5328
==========================================
+ Hits 2846 2849 +3
+ Misses 2086 2083 -3
Partials 396 396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies how WorkloadScan determines the “workload” for a Pod by describing which ownerReference chains are walked and how WorkloadScanReport names are derived from the resolved owner kind/UID (including mirror/static Pods owned by Node).
Changes:
- Rewords “Supported workload types” to describe report creation per resolved top-level owner rather than a fixed whitelist.
- Documents the two special ownerReference chains that are walked (ReplicaSet → Deployment, Job → CronJob).
- Explicitly notes that other controller owner kinds (e.g.,
Node, custom CRDs) produce reports named<kind>-<uid>.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4153faa to
35c961e
Compare
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
35c961e to
084f2dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
clarify workload owner kinds supported by WorkloadScan
Fixes #938