test: fix hedge-walk mock queues so cap logic is actually exercised - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the hedge-walk unit tests added in PR #118 — mock queues were ordered incorrectly, so the PE-hedge walk never exercised the cap logic.
Why
The 3 tests added with PR #118 used
.mockResolvedValue(false)(a default) interleaved with.mockResolvedValueOnce()entries. Jest consumes once-queue values in registration order BEFORE falling back to the default — so the PE hedge "succeeded" on its first attempt (consuming the value meant for CE Sell) and the walk/cap code path was never tested. Result: tests expected 8 calls, got 4, and CI on development was red after the docs PR #119 merged.Change
Rewrote the 3 tests with fully deterministic
mockResolvedValueOncequeues matching the exact call sequence (CE hedge + 6 PE attempts + 2 sells = 9 calls; CE-walk variant = 6; CE-cap variant = 9).Verification