Add Windows (MSYS2/Git Bash) support for process introspection#247
Open
mattmarcin wants to merge 1 commit into
Open
Add Windows (MSYS2/Git Bash) support for process introspection#247mattmarcin wants to merge 1 commit into
mattmarcin wants to merge 1 commit into
Conversation
MSYS2's `ps` has no `-o` flag, so firstmate's harness-ancestry walk (fm-lock.sh, fm-harness.sh) and pid fingerprint (fm-wake-lib.sh) fail with "ps: unknown option -- o" on Git Bash. Add bin/fm-ps-portable.sh (fm_ps_field comm|args|ppid|identity): native `ps -o` on macOS/Linux, `ps -f` fallback where `-o` is unavailable - mirroring the existing stat -f/-c platform branch. Route the 9 ps -o sites through it and add tests/fm-ps-portable.test.sh. No behavior change on macOS/Linux (native path is byte-identical).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSYS2's
pshas no-oflag, so firstmate's harness-ancestry walk (fm-lock.sh, fm-harness.sh) and pid fingerprint (fm-wake-lib.sh) fail with "ps: unknown option -- o" on Git Bash.Add bin/fm-ps-portable.sh (fm_ps_field comm|args|ppid|identity): native
ps -oon macOS/Linux,ps -ffallback where-ois unavailable - mirroring the existing stat -f/-c platform branch. Route the 9 ps -o sites through it and add tests/fm-ps-portable.test.sh.No behavior change on macOS/Linux (native path is byte-identical).