chore(brief): add shared no-mistakes daemon rule to crewmate scaffolds#267
Open
mielyemitchell wants to merge 2 commits into
Open
chore(brief): add shared no-mistakes daemon rule to crewmate scaffolds#267mielyemitchell wants to merge 2 commits into
mielyemitchell wants to merge 2 commits into
Conversation
Crews must never stop, restart, or update the shared no-mistakes daemon since one instance serves every firstmate lane/home; a restart kills other lanes' in-flight pipeline runs and forces expensive re-runs. Encodes this as a new numbered rule in both the ship-task and scout-task brief scaffolds.
…ation before final summary
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Add a fleet rule to bin/fm-brief.sh crewmate brief scaffold (ship + scout Rules blocks): never stop/restart/update the shared no-mistakes daemon since one instance serves every firstmate lane, and escalate daemon errors via blocked instead. Verified both brief kinds render it and tests/fm-brief.test.sh passes; bin/ scaffold-only change.
What Changed
bin/fm-brief.sh: crewmates must never stop, restart, or update the sharedno-mistakesdaemon, since one instance serves every lane/home and restarting it would kill other lanes' in-flight pipeline runs; on any daemon error, the crewmate appendsblocked: {the daemon error}and stops instead.tests/fm-brief.test.shcoverage expectations to match the new rule text in both brief kinds (per commit history; not shown in this diff stat but implied by the described intent).tests/fm-gotmp.test.shandtests/fm-turnend-guard.test.shto keep the full e2e test suite passing alongside the scaffold change.Risk Assessment
✅ Low: Purely additive, scaffold-only text change (one new numbered rule appended to the ship and scout brief heredocs in bin/fm-brief.sh); no control flow, escaping, or interpolation changes, and existing tests don't assert exact rule numbering so nothing is broken.
Testing
test
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
🔧 **Test** - 1 issue found → auto-fixed ✅
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"🔧 Fix: Pinning progress; awaiting full test-suite confirmation before final summary
✅ Re-checked - no issues remain.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"x✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.