fix(backends): resolve physical path in orca repo_ensure for symlinked projects#279
Open
BenWilcox8 wants to merge 5 commits into
Open
fix(backends): resolve physical path in orca repo_ensure for symlinked projects#279BenWilcox8 wants to merge 5 commits into
BenWilcox8 wants to merge 5 commits into
Conversation
…d projects Secondmate homes hold project clones as symlinks to the primary's canonical clones. fm-spawn computes PROJ_ABS with logical pwd, so the symlink path reached orca repo add --path, minting a duplicate repo entry instead of reusing the canonical one. In fm_backend_orca_repo_ensure, resolve the project directory to its physical path (cd <dir> && pwd -P) before passing it to orca repo show and orca repo add. Keeps the fix scoped to the Orca backend; other backends are unaffected. Update three existing tests that passed the non-existent path /repo/path to use real directories, since the physical-path resolution now requires the directory to exist. Add a new test proving a symlinked project dir resolves to the same canonical physical path as the canonical dir itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fm_backend_orca_repo_ensurenow resolves the project directory to its physical path (cd <dir> && pwd -P) before passing it toorca repo showandorca repo add --pathTest plan
test_repo_ensure_resolves_symlinked_project_to_physical_pathproves a symlinked project dir resolves to the same canonical physical path as the canonical dir itselfbin/*.sh bin/backends/*.sh tests/*.sh🤖 Generated with Claude Code