feat(viewer): add redacted diagnostics event API - #1648
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecde519870
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ecde519 to
4b6ef61
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b6ef61614
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4b6ef61 to
03a2437
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03a24375b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ELSE 'unspecified' | ||
| END AS category | ||
| FROM raw_event_flush_batches | ||
| WHERE status IN ('error', 'failed', 'gave_up') ${providerFilter}`; |
There was a problem hiding this comment.
On databases with many retained failed or retry-exhausted flush batches, the default diagnostics request evaluates every matching row before the outer ORDER BY ... LIMIT in boundedSourceSelect. I checked this query against the existing (status, updated_at) index: because it filters three statuses and globally orders by updated_at plus the computed key, SQLite reports a temporary B-tree and scans all terminal failures. Since these rows have no retention cleanup and the drawer is intended to poll, select an indexed recent window per status or add an order-compatible access path before cross-source sorting.
Useful? React with 👍 / 👎.
| FROM raw_event_sessions AS sessions | ||
| WHERE EXISTS (SELECT 1 FROM raw_events AS events | ||
| WHERE events.source = sessions.source | ||
| AND events.stream_id = sessions.stream_id | ||
| AND events.event_seq > sessions.last_flushed_event_seq) |
There was a problem hiding this comment.
When a long-running database has accumulated many raw_event_sessions, every default or capture diagnostics request scans the entire sessions table and runs a correlated raw_events existence lookup for each row before sorting and applying LIMIT 1000. Purged sessions remain in this table, and its only index is the (source, stream_id) primary key, so the limit bounds aggregation output but not polling work; derive the backlog from an indexed pending-session set or otherwise bound the session scan first.
Useful? React with 👍 / 👎.
03a2437 to
270265e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 270265e3c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } while (cursor); | ||
|
|
||
| expect(events).toHaveLength(17); | ||
| expect(new Set(events.map((event) => event.id))).toHaveLength(17); |
There was a problem hiding this comment.
When this pagination test runs, toHaveLength(17) inspects a length property, but a JavaScript Set exposes its count through size; the assertion therefore fails even when all 17 event IDs are unique, breaking the repository's test gate. Assert new Set(...).size with toBe(17) as the earlier pagination assertion does.
AGENTS.md reference: AGENTS.md:L18-L19
Useful? React with 👍 / 👎.
1 participant
Description
Adds the redacted diagnostics event contract and
GET /api/diagnostics/events, including bounded source queries, authenticated cursor pagination, stable ordering, safe recovery metadata, and adversarial redaction coverage. The design document records the privacy and interaction contract used by the rest of the stack.Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test)Checklist
pnpm run lintpasses for touched files)