Return latest frozen var buffer if available#67
Open
TylerAgostino wants to merge 1 commit into
Open
Conversation
Add a check to return the latest frozen var buffer if it exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check to return the latest frozen var buffer if it exists. Without this check, the var buffers are sorted by the header's tick_count which is not frozen. So the frozen var buffer is only returned 1 in 3 frames of data, and the values switch back and forth between the frozen frame and live frames when monitored continuously. Since
__var_buffer_latestis only set to a value withinfreeze_var_buffer_latest, and set back to None withinunfreeze_var_buffer_latest, it seems like this was its original purpose.This undoes part of a change introduced here.