[Store] Persist and recover DFS allocator metadata - #4018
Draft
fcczzz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the standalone DFS allocator recovery proposed in #3819.
Previously,
DfsGlobalAllocatorlost allocation ownership on Master restart, allowing ranges referenced by restored metadata to be reused. This change persists allocator state in per-shard checkpoints and WALs, then reconciles recovered allocations with standalone Master snapshots before serving requests.ALLOCbefore exposing a descriptor andRELEASEbefore reusing a deferred extent.Two details adapt the RFC to the current implementation:
MOONCAKE_DFS_METADATA_WAL_COMPACTION_THRESHOLD_BYTES.Compatibility and scope
The DFS descriptor format and client data path remain unchanged. Existing roots containing only
.datafiles cannot be migrated in place; upgrade and rollback require a new empty DFS root.This supports standalone Master recovery. HA, OpLog recovery, standby promotion, and multi-tenant DFS remain unsupported. Allocator metadata persistence does not add data-file
fsyncdurability.Module
mooncake-store)Type of Change
How Has This Been Tested?
Test commands:
All four test targets passed, including 55 DFS tests. Coverage includes allocation recovery, durable release, torn WAL tails, corrupt checkpoints, namespace mismatches, orphan reconciliation, and recovery after online expansion.
Test results:
Checklist
./scripts/code_format.shAI Assistance Disclosure