[Store] Support namespace registration without target SPDK RPC - #4035
Open
cage-goat wants to merge 1 commit into
Open
[Store] Support namespace registration without target SPDK RPC#4035cage-goat wants to merge 1 commit into
cage-goat wants to merge 1 commit into
Conversation
The registration CLI requires SSH access and target-side SPDK RPC to discover namespace capacity. Add a master RPC to query namespace capacity and block size over NVMe-oF and register the full namespace. Expose query_and_register in Python and add namespace endpoint options to the registration CLI.
cage-goat
requested review from
ShangmingCai,
UNIDY2002,
XucSh,
YiXR,
alogfans,
staryxchen,
stmatengss,
ykwd and
zxpdemonio
as code owners
September 11, 2026 07:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4034.
The registration CLI requires SSH access and target-side SPDK management RPC to discover namespace capacity.
Add a master RPC to query namespace capacity and block size over NVMe-oF and register the full namespace. Expose
query_and_registerin Python and add namespace endpoint options to the registration CLI.Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
Run from the validation directory containing the NOF ON/OFF builds:
ctest --test-dir build-on --output-on-failure --timeout 60 \ -R '^(nof_heartbeat_test|nof_register_config_test)$' ctest --test-dir build-off --output-on-failure --timeout 60 \ -R '^nof_register_config_test$'Test results:
Validated with SPDK 23.01.1 malloc bdevs over NVMe/TCP:
Checklist
./scripts/code_format.shAI Assistance Disclosure
OpenAI Codex assisted with implementation, code review, documentation, and validation.