[Store] Add WeightRevision metadata registry (RFC #4017 ) - #4043
Open
huangxiaobai-ydmy wants to merge 4 commits into
Open
[Store] Add WeightRevision metadata registry (RFC #4017 )#4043huangxiaobai-ydmy wants to merge 4 commits into
huangxiaobai-ydmy wants to merge 4 commits into
Conversation
…(PR1) Introduce in-memory WeightMetadataStore with Begin/Commit import (READY+HOT), get/list/update APIs, Master RPC wiring, and tests. Co-authored-by: Cursor <cursoragent@cursor.com>
huangxiaobai-ydmy
requested review from
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
September 11, 2026 09:19
Align changed lines with clang-format-20 so CI format check passes. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
Will there be an API to revoke or delete? If we encounter an error when transferring model weights, we may need to delete it to leave space for another model weight transfer. Correct me if I missed some context or if this failure pattern is handled by other mechanisms. |
Allow reclaiming space after a mid-transfer failure (AbortWeightImport) and deleting published revisions (RemoveWeightRevision). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Thanks @Aionw — good catch. That failure path was missing in PR1. I added:
Happy to adjust naming / semantics if you prefer folding abort into a single |
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partial implementation of RFC #4017 (revision-level Weight Management), slice PR1.
Adds an in-memory
WeightMetadataStoreand Master/client/RPC APIs so a weight revision can be:BeginWeightImport(IMPORTING, invisible to Get/List)CommitWeightImportas READY + HOT after payload/manifest keys existGetWeightMetadata/ListWeightRevisionsUpdateWeightPolicyRelated: #4017
Out of scope for this PR
Python
weight_*API convergence, HA OpLog/snapshot, residency migration, and revision leases.Follow-up plan (3+1)
PR2 - safe read path + protect managed groups
weight_get(TTL; blocks delete / release of existing readable replicas while held; allows creating new replicas)BatchEvict/ single-keyRemove/ cleanup skip members of a published weight group (with a skip metric)PR3 - residency migration
weight_migrate(HOT / COLD / MIXED) with operation records + batched progressPR4 (optional / later) - HA + API convergence
weight_management_oplog_capability_confirmedrolling-upgrade gateweight_*surface (remove unmanaged entry points last)Happy to adjust these boundaries based on maintainer feedback.
Module
mooncake-store)mooncake-transfer-engine)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
Test results:
Checklist
./scripts/code_format.shAI Assistance Disclosure
Cursor / Composer assisted with implementing the WeightMetadataStore, Master RPC wiring, and tests against RFC #4017. The submitter reviewed the changes.