[Store] Add post-publish snapshot object GC - #4049
Draft
Icedcoco wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initial N11 implementation for #3167 and #3808: after successful batch-OpLog snapshot publication, read latest/fallback manifests and delete unprotected attempt prefixes under the batch-oplog object root. New code lives under ha/snapshot/batch_oplog/.
This draft is incomplete and not ready to merge. Remaining work includes exact post-publish pointer comparison, full manifest/artifact validation, lease rechecks before deletion, promotion/Stop cancellation, exception isolation preserving successful publication, and GC/integration tests.
Scope differs from #3221 (LOCAL_DISK bucket GC) and #1381 (etcd snapshot object-store backend): this change targets batch-OpLog snapshot attempts only; it does not prune OpLog or set compaction floors.
Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Pre-commit passed on the four changed files, including formatting during commit. Build attempted but could not run because this worktree has no build directory. No unit or integration tests were run.
Test commands:
Test results:
Checklist
./scripts/code_format.shAI Assistance Disclosure
Codex generated the implementation and PR description. Human review of every changed line remains pending.