[Bugfix][TE] Fix Ascend wildcard location fallback and 64KB memory alignment - #4053
Closed
gygdh-001 wants to merge 1 commit into
Closed
[Bugfix][TE] Fix Ascend wildcard location fallback and 64KB memory alignment#4053gygdh-001 wants to merge 1 commit into
gygdh-001 wants to merge 1 commit into
Conversation
ResolveAscendMemType() treated aclrtPointerGetAttributes() failure as a hard
error (CHECK_ACL returned -1), so registering host memory with the wildcard
location ("*") failed on Ascend. CUDA already falls back when the wildcard
probe cannot identify the memory; align Ascend by treating probe failure as
host memory (adxl::MEM_HOST).
initMemoryAllocator()'s fallback path used plain malloc(), whose address is
not 64KB page-aligned. Ascend SVM (_devmm_mem_remote_map) requires a
64KB-aligned src_va, so aclrtHostRegister failed with EINVAL. Use
posix_memalign(64KB) for the default allocator instead.
gygdh-001
requested review from
ShangmingCai,
alogfans and
ascend-direct-dev
as code owners
September 11, 2026 12:12
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two defects that prevent host-memory registration on the Ascend transfer engine (see #4046):
Wildcard location probe falls back to host memory (
ascend_direct_transport.cpp)ResolveAscendMemType()previously usedCHECK_ACL, treating anaclrtPointerGetAttributes()failure as a hard error (returning -1). As a result,registering host memory (hugepage / shm /
malloc) with the wildcard location"*"failed on Ascend. CUDA already falls back when the wildcard probe cannot identify the
memory; this change aligns Ascend by treating the probe failure as host memory
(
adxl::MEM_HOST). This matches the existing fix for the heterogeneous RDMA transport(fix: fix heterogeneous rdma transport error #1657).
64KB-aligned default allocator (
transfer_engine_py.cpp)initMemoryAllocator()'s fallback path used plainmalloc, whose address is not64KB page-aligned. Ascend SVM (
_devmm_mem_remote_map) requires a 64KB-alignedsrc_va, soaclrtHostRegisterfailed with EINVAL. The fallback now usesposix_memalign(64 * 1024, ...).Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Manual verification on Ascend 910B (bare
mooncake.engineTE path):rdmapath reaches 7.2 GB/s (1MB block × batch16 × 10rounds, all ok).
aclrtHostRegisterno longer fails with EINVAL.heterogeneous-RDMA transport (fix: fix heterogeneous rdma transport error #1657).
Test commands:
# Manual verification on Ascend 910BTest results:
Checklist
./scripts/code_format.shAI Assistance Disclosure