Conversation
12 tasks
Move registration and resource-operation serialization into replaceable client slots, keeping liveness observations independent of slow remount work. Preserve incarnation validation, restore coordination, and readiness accounting without long-held registry locks. Cover concurrent admission, rollback, removal, restore, observer shutdown, and slot replacement. Add a disabled manual regression experiment for kvcache-ai#3936. Validation: 249 tests passed across liveness, session manager, MasterService, HA, and segment suites; liveness/session suites repeated 50 times. The kvcache-ai#3936 fault-injection experiment also passed. File-scoped prek checks passed except the unavailable clang-format-20 hook; changed lines were checked with clang-format 22. AI-assisted implementation and testing.
Aionw
marked this pull request as ready for review
September 18, 2026 08:27
Aionw
requested review from
00fish0,
Icedcoco,
Libotry,
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
September 18, 2026 08:27
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Centralize client registration, remount readiness, heartbeat/liveness monitoring, host hints, and offboarding lifecycle in
ClientSessionManagerinstead ofMasterService.ClientSessionSharedPtr; replacing a session invalidates old segment generations rather than silently transferring their resources.Related work and scope
Searched existing issues/open PRs for client sessions and liveness before opening:
Draft blockers
This is a substantive change exceeding 500 LOC. A dedicated RFC has not yet been filed/linked. Human confirmation of reviewing every changed line is also pending; keep this PR in draft until both are addressed.
Module
mooncake-transfer-engine)mooncake-store)mooncake-conductor)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Local selected-target build and tests passed. HA/snapshot tests were adapted but not run in this submission; full integration and hardware-specific configurations remain unvalidated.
Test commands:
Test results:
All applicable lightweight hooks passed except
mooncake-code-format: it requires unavailable clang-format 20 (the host provides 22.1.8). Changed-line clang-format 22 was used for the final inline-review edits, not claimed as a full PR formatting pass. The build emitted warnings from bundled fmt headers.Checklist
./scripts/code_format.shAI Assistance Disclosure
OpenAI Codex assisted with code changes, inline-review follow-up, validation, and PR preparation. Human end-to-end review and responsibility confirmation remain pending; no claim of completed human review is made.