Conversation
Signed-off-by: Schatten <czhengt@qq.com>
bitborne
requested review from
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
September 17, 2026 16:57
Aionw
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #3809. Extract
MC_STORE_REGISTER_SPDKfromshm_helper.cppinto a private, client-ownedShmSpdkRegistrationConfigand the common environment catalog.ShmHelperstill reads the flag once during singleton construction, and only the exact value1enables registration; unset, empty, and other values remain disabled. The hugepage and SPDK registration behavior is otherwise unchanged.The raw string preserves the original strict comparison rather than adopting a generic boolean parser. This follows the single-owner configuration boundary of merged #4165 and #4166 and complements the existing registration feature in merged #3717. Open #4179 moves the client source layout without migrating this flag; integration conflicts can be addressed if it merges first.
Module
mooncake-store)mooncake-common)Type of Change
How Has This Been Tested?
Test commands:
cmake --build build/config-check --target shm_spdk_registration_config_test --parallel 231 ctest --test-dir build/config-check -R '^shm_spdk_registration_config_test$' --output-on-failure ./scripts/code_format.sh --check --staged pre-commit run --files mooncake-common/include/environment_variables.h mooncake-store/src/CMakeLists.txt mooncake-store/src/config/shm_spdk_registration_config.cpp mooncake-store/src/config/shm_spdk_registration_config.h mooncake-store/src/shm_helper.cpp mooncake-store/tests/CMakeLists.txt mooncake-store/tests/shm_spdk_registration_config_test.cppTest results:
The new test first failed for
MC_STORE_REGISTER_SPDK=1with the default-only implementation and passed after the configuration extraction.Checklist
./scripts/code_format.shNo documentation change: the existing strict opt-in behavior is unchanged.
AI Assistance Disclosure
Codex assisted with ownership analysis, implementation, focused RED-to-GREEN tests, and review. The human submitter will review every changed line and is responsible for the change end to end.