Conversation
anranxia
marked this pull request as ready for review
September 18, 2026 04:24
anranxia
requested review from
ShangmingCai,
UNIDY2002,
alogfans,
chestnut-Q,
doujiang24,
staryxchen,
stmatengss and
ykwd
as code owners
September 18, 2026 04:24
Contributor
Author
|
The CI failure appears unrelated to this PR. Of 215 CTest targets, only This matches the known issue addressed by #4210: the test counts all threads under The RDMA-related CTest targets, build, formatting, and documentation checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Classic TE sends notifications over TCP even when data transfers use ordinary RDMA. This adds a synchronous TCP round trip to transfers that request notifications.
This PR adds native SEND/RECV notifications to ordinary
RdmaTransport:MC_RDMA_NOTIFY_ENABLEDandMC_RDMA_NOTIFY_OOB_FALLBACK, without adding configuration variables or changingrdma_twosided.A successful native notification send indicates local submission, not confirmed remote receipt. Unsupported peers and oversized messages may fall back to TCP when enabled; failed or uncertain sends are not replayed.
Each endpoint uses 32 MiB of registered host memory for notification buffers. The maximum combined
nameandmsgsize is 65,528 bytes.Module
mooncake-transfer-engine)Type of Change
How Has This Been Tested?
Release/CUDA builds succeeded on two RDMA hosts.
Regression tests:
All 34 tests passed: 20 notification tests, 8 endpoint-state tests, and 6 endpoint-store tests.
Coverage includes concurrent sends, endpoint reuse and restart, backpressure, fallback, shared-CQ growth, stale completions, and capacity failures.
Performance testing:
Unmodified nixlbench v1.4.1, two NVIDIA H20-3e hosts, GPU-to-GPU READ/WRITE, one logical RDMA device per host, batch=1, one thread, pipeline depth=1, notifications enabled. Each block size used 100 warmup iterations and 1,000 measured iterations, with one sweep per configuration.
The same NIXL binary and plugin loaded either the baseline or modified TE library. All 60 configurations completed successfully.
Latency and bandwidth are taken directly from nixlbench output.
Test results:
Checklist
./scripts/code_format.shAI Assistance Disclosure
OpenAI Codex assisted with implementation, tests, benchmarking, and documentation. The human submitter is responsible for reviewing every changed line before submission.