[perf](sft): accelerate FP8 training with shared repack and decoded tiles - #2193
Draft
yyj6666667 wants to merge 4 commits into
Draft
[perf](sft): accelerate FP8 training with shared repack and decoded tiles#2193yyj6666667 wants to merge 4 commits into
yyj6666667 wants to merge 4 commits into
Conversation
Keep only shared backward-repack ownership, the SFT integration, and FP8 packed transpose/GEMM changes. Remove the benchmark harness, added test files, documentation, and optional profiling/tracing additions from the upstream diff. The original commits and private experiment archive preserve the removed material; validation runs outside the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2141 and #2188, limited to five production headers:
Frozen weights and the shared backward BufferB remain FP8 plus scales.
No benchmark harness, added test files, documentation, CMake changes, NVTX tracing
or extra profiler statistics are included in the aggregate diff. The existing
upstream tests are unchanged.
Performance and verification
DeepSeek V3.1 FP8 LoRA SFT on two EPYC 9355 CPUs and eight RTX 5090 GPUs:
sequence 1024, batch 1/GPU, GAS 1, 64 CPU workers/TP2, LoRA rank 8/alpha 16,
CPU retain / GPU recompute. A/B/B/A means were 62.1535 -> 136.4012 global
tokens/s (2.1946x), with 2 warmup + 16 measured updates per run.
All four short fixture runs had finite loss and gradients, with loss
12.671875 -> 11.8515625; this is not a long-term convergence claim.
Performance was measured before PR packaging and this scope reduction, not
retimed on the core-only binary. The core-only revision
7db13789was separatelyrebuilt on base
9b0da97cwith GCC 11.4 / CUDA 12.8 / AVX512-BF16/VBMI and checkedusing external validation fixtures: 274 bitwise FP8 GEMM comparisons, parallel
packed-byte/scale transpose, repack lifecycle, and 30 native pipeline cases.
Validation fixtures are not part of this PR's file diff.
Draft integration boundary
Upstream #2186 subsequently added a separate
AMX_K2_SFT_MOE_TPthat stillexposes
prepare_backward_bb_for_async(); this wrapper expectsprepare_shared_backward_weights()andinvalidate_backward_repack().That interface integration and a rebuilt/tested merge head remain required
before merge. The newer
aa2cd307configuration and upstream CI are not claimedas validated. This PR does not add RAWINT4/INT8 performance work.