Skip to content

chore: pin pnpm to latest v10#1440

Open
SameDesu123 wants to merge 3 commits into
kwaroran:mainfrom
SameDesu123:chore/pnpm-v10-fixed
Open

chore: pin pnpm to latest v10#1440
SameDesu123 wants to merge 3 commits into
kwaroran:mainfrom
SameDesu123:chore/pnpm-v10-fixed

Conversation

@SameDesu123
Copy link
Copy Markdown
Contributor

@SameDesu123 SameDesu123 commented May 11, 2026

PR Checklist

  • Required Checks
    • Have you added type definitions?
    • Have you tested your changes?
    • Have you checked that it won't break any existing features?
  • If your PR uses models1, check the following:
    • Have you checked if it works normally in all models?
    • Have you checked if it works normally in all web, local, and node-hosted versions? If it doesn't, have you blocked it in those versions?
  • If your PR is highly AI generated2, check the following:
    • Have you understood what the code does?
    • Have you cleaned up any unnecessary or redundant code?
    • Is it not a huge change?
      • We currently do not accept highly AI generated PRs that are large changes.

Summary

Pins package-manager resolution to pnpm 10.34.1 so CI, Docker, and server bootstrap scripts do not unintentionally move to pnpm v11.

Related Issues

Fixes #1439

Changes

  • Added packageManager: "pnpm@10.34.1" to package.json.
  • Changed GitHub Actions pnpm setup from latest to 10.34.1.
  • Changed Docker Corepack installation from pnpm@latest to pnpm@10.34.1.
  • Changed Unix and Windows server bootstrap scripts to install pnpm@10.34.1.

Impact

This keeps installs on pnpm 10.34.1 while avoiding an accidental pnpm v11 upgrade. That preserves compatibility with the project's current Node.js 20 support until a dedicated pnpm v11 migration is ready.

Additional Notes

Validation performed:

  • node -e "JSON.parse(require('fs').readFileSync('package.json','utf8')); console.log('package.json ok')"
  • git diff --check upstream/main..HEAD
  • rg -n "pnpm@latest-10|latest-10" .github Dockerfile server.sh server.bat package.json

Footnotes

  1. Modifies the behavior of prompting, requesting, or handling responses from AI models.

  2. Over 80% of the code is AI generated.

@SameDesu123 SameDesu123 marked this pull request as ready for review May 11, 2026 14:41
@tasoo-oos tasoo-oos mentioned this pull request May 20, 2026
10 tasks
Copy link
Copy Markdown
Collaborator

@cubicj cubicj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpm v10 pinning direction looks good, but packageManager cannot use pnpm@latest-10.

I checked with Corepack, and it fails with expected a semver version.

Could you change packageManager to an exact pnpm v10 version?

@SameDesu123 SameDesu123 force-pushed the chore/pnpm-v10-fixed branch from 67947a1 to 9b2e31a Compare May 29, 2026 13:57
@SameDesu123
Copy link
Copy Markdown
Contributor Author

Thanks for the review! As you suggested, I updated the packageManager value to an exact pnpm version pnpm@10.34.1. Thanks for catching this!

@SameDesu123 SameDesu123 requested a review from cubicj May 29, 2026 14:06
Copy link
Copy Markdown
Collaborator

@cubicj cubicj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the follow-up. Thanks for taking the review feedback and updating packageManager and the pnpm install paths to the exact 10.34.1 version.

Check, tests, and build pass locally.

Approving — thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin pnpm to v10 until pnpm v11 migration is ready

2 participants