chore: pin pnpm to latest v10#1440
Open
SameDesu123 wants to merge 3 commits into
Open
Conversation
10 tasks
10 tasks
cubicj
reviewed
May 29, 2026
Collaborator
cubicj
left a comment
There was a problem hiding this comment.
The pnpm v10 pinning direction looks good, but packageManager cannot use pnpm@latest-10.
I checked with Corepack, and it fails with expected a semver version.
Could you change packageManager to an exact pnpm v10 version?
67947a1 to
9b2e31a
Compare
Contributor
Author
|
Thanks for the review! As you suggested, I updated the |
cubicj
approved these changes
May 30, 2026
Collaborator
cubicj
left a comment
There was a problem hiding this comment.
Verified the follow-up. Thanks for taking the review feedback and updating packageManager and the pnpm install paths to the exact 10.34.1 version.
Check, tests, and build pass locally.
Approving — thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Pins package-manager resolution to pnpm 10.34.1 so CI, Docker, and server bootstrap scripts do not unintentionally move to pnpm v11.
Related Issues
Fixes #1439
Changes
packageManager: "pnpm@10.34.1"topackage.json.latestto10.34.1.pnpm@latesttopnpm@10.34.1.pnpm@10.34.1.Impact
This keeps installs on pnpm 10.34.1 while avoiding an accidental pnpm v11 upgrade. That preserves compatibility with the project's current Node.js 20 support until a dedicated pnpm v11 migration is ready.
Additional Notes
Validation performed:
node -e "JSON.parse(require('fs').readFileSync('package.json','utf8')); console.log('package.json ok')"git diff --check upstream/main..HEADrg -n "pnpm@latest-10|latest-10" .github Dockerfile server.sh server.bat package.jsonFootnotes
Modifies the behavior of prompting, requesting, or handling responses from AI models. ↩
Over 80% of the code is AI generated. ↩