Skip to content

feat: Cancel Account Sync Option#1457

Open
sub-hub wants to merge 1 commit into
kwaroran:mainfrom
sub-hub:cancelAccountSyncOption
Open

feat: Cancel Account Sync Option#1457
sub-hub wants to merge 1 commit into
kwaroran:mainfrom
sub-hub:cancelAccountSyncOption

Conversation

@sub-hub
Copy link
Copy Markdown
Collaborator

@sub-hub sub-hub commented May 20, 2026

PR Checklist

  • Required Checks
    • Have you added type definitions?
    • Have you tested your changes?
    • Have you checked that it won't break any existing features?
  • If your PR uses models1, check the following:
    • Have you checked if it works normally in all models?
    • Have you checked if it works normally in all web, local, and node-hosted versions? If it doesn't, have you blocked it in those versions?
  • If your PR is highly AI generated2, check the following:
    • Have you understood what the code does?
    • Have you cleaned up any unnecessary or redundant code?
    • Is it not a huge change?
      • We currently do not accept highly AI generated PRs that are large changes.

Summary

image

Add third option to checkAccountSync page, Cancel Account Sync.

Description

Actually, users can already cancel account sync by selecting Save Current Data to Account and type a random string in the confirm input.

            const confirm = await alertInput(`to overwrite your data, type "RISUAI"`)
            if(confirm !== "RISUAI"){
                localStorage.setItem('dosync', 'avoid')
                return false
            }

However, this is a very unfriendly way of doing things. Who would risk overwriting their own data just to cancel account sync?

So, I'd really like to see this PR merged. It would be much more intuitive to have a cancel button rather than telling people who don't want the sync to just overwrite and cancel the data.

Footnotes

  1. Modifies the behavior of prompting, requesting, or handling responses from AI models.

  2. Over 80% of the code is AI generated.

Copy link
Copy Markdown
Collaborator

@cubicj cubicj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the account sync decision path. I had also run into this before, and the new cancel option gives account sync users a clear safe path instead of the overwrite-confirm workaround.

Check, tests, and build pass locally.

Approving — thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants