Skip to content

fix: cbs reverse, setdefaultvar#1461

Merged
cubicj merged 3 commits into
kwaroran:mainfrom
tammy3211:fix/cbs
Jun 3, 2026
Merged

fix: cbs reverse, setdefaultvar#1461
cubicj merged 3 commits into
kwaroran:mainfrom
tammy3211:fix/cbs

Conversation

@tammy3211
Copy link
Copy Markdown
Contributor

PR Checklist

  • Required Checks
    • Have you added type definitions?
    • Have you tested your changes?
    • Have you checked that it won't break any existing features?
  • If your PR uses models1, check the following:
    • Have you checked if it works normally in all models?
    • Have you checked if it works normally in all web, local, and node-hosted versions? If it doesn't, have you blocked it in those versions?
  • If your PR is highly AI generated2, check the following:
    • Have you understood what the code does?
    • Have you cleaned up any unnecessary or redundant code?
    • Is it not a huge change?
      • We currently do not accept highly AI generated PRs that are large changes.

Summary

fix cbs reverse, setdefaultvar

Related Issues

"None".

Changes

fix cbs reverse, setdefaultvar

Impact

Additional Notes

Footnotes

  1. Modifies the behavior of prompting, requesting, or handling responses from AI models.

  2. Over 80% of the code is AI generated.

@tammy3211 tammy3211 changed the title Fix/cbs fix: cbs reverse, setdefaultvar May 24, 2026
@sub-hub
Copy link
Copy Markdown
Collaborator

sub-hub commented May 28, 2026

Every fix is a small fix, and the bugs are critical. Thank you for the PR.

Just one thing: there was a test for reverse cbs in the strings.test.ts file, but it had been skipped because it was failing.
Since this PR fixes that error, it seems like a good to stop skipping the reverse test in this PR too.

Copy link
Copy Markdown
Collaborator

@sub-hub sub-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image Now the reverse test is working properly. Thank you!

Copy link
Copy Markdown
Collaborator

@cubicj cubicj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the CBS behavior. setdefaultvar now treats the existing getChatVar() "null" sentinel as unset, and reverse now operates on the parsed argument instead of the whole CBS match.

Check, tests, and build pass locally.

Approving — thanks for the contribution!

@cubicj cubicj merged commit 0999071 into kwaroran:main Jun 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants