fix: cbs reverse, setdefaultvar#1461
Merged
Merged
Conversation
Collaborator
|
Every fix is a small fix, and the bugs are critical. Thank you for the PR. Just one thing: there was a test for reverse cbs in the strings.test.ts file, but it had been skipped because it was failing. |
cubicj
approved these changes
Jun 3, 2026
Collaborator
cubicj
left a comment
There was a problem hiding this comment.
Verified the CBS behavior. setdefaultvar now treats the existing getChatVar() "null" sentinel as unset, and reverse now operates on the parsed argument instead of the whole CBS match.
Check, tests, and build pass locally.
Approving — thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Checklist
Summary
fix cbs reverse, setdefaultvar
Related Issues
"None".
Changes
fix cbs reverse, setdefaultvar
Impact
Additional Notes
Footnotes
Modifies the behavior of prompting, requesting, or handling responses from AI models. ↩
Over 80% of the code is AI generated. ↩