You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 22, 2024. It is now read-only.
Added a short argument to write functions of Tier and TextGrid classes. If short=True the tiers/textgrids are written in the abbreviated short format. Default value of short is set to False, so it should be backward compatible.
I like the idea of adding support for this but repeatedly switching on a single constant boolean inside of a loop is IMO poor design. It should just be if short: ...else: at most one time. Would you be willing to refactor for that? (Or just call the method write_short and put it somewhere else.)
I don't use (or understand why anyone else would use) the short format, and we don't yet support its reading either, so this strikes me as a low priority.
Good point. Will implement write_short if I have some spare time. AFAIK the short format is mostly used for large corpora as it saves some space. I'm converting output from a forced aligner to short textgrids so I can more easily compare them to the short textgrids from some of those corpora.
As far as I can tell reading short TextGrids works just fine, btw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
shortargument towritefunctions of Tier and TextGrid classes. Ifshort=Truethe tiers/textgrids are written in the abbreviated short format. Default value ofshortis set toFalse, so it should be backward compatible.