PR1.3: add duration mismatch diagnostic#92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #75.
Adds an explicit deterministic duration-ratio diagnostic inside
input_suitabilityso reports can warn when a take is much longer or shorter than the reference before users interpret the score too confidently.Changed
duration_diagnosticandduration_diagnostic_messagetoInputSuitabilitySummary.duration_ratio_oktake_much_longer_than_referencetake_much_shorter_than_referenceduration_ratio_unavailableTests
Not run locally in this environment: repository execution is handled through GitHub connector only here. The previous CI run for PR1.2 was green after contract fixes, and this PR is limited to additive duration diagnostic fields plus matching tests.