Skip to content

PR1.3: add duration mismatch diagnostic#92

Merged
kymuco merged 7 commits into
mainfrom
feat/pr1.3-duration-mismatch-diagnostic
May 30, 2026
Merged

PR1.3: add duration mismatch diagnostic#92
kymuco merged 7 commits into
mainfrom
feat/pr1.3-duration-mismatch-diagnostic

Conversation

@kymuco
Copy link
Copy Markdown
Owner

@kymuco kymuco commented May 30, 2026

Summary

Closes #75.

Adds an explicit deterministic duration-ratio diagnostic inside input_suitability so reports can warn when a take is much longer or shorter than the reference before users interpret the score too confidently.

Changed

  • Added duration_diagnostic and duration_diagnostic_message to InputSuitabilitySummary.
  • Derived the diagnostic from prepared feature durations, not guessed musical intent.
  • Added machine-readable states:
    • duration_ratio_ok
    • take_much_longer_than_reference
    • take_much_shorter_than_reference
    • duration_ratio_unavailable
  • Added warning text that mentions possible causes: extra silence, restart, missing section, or unrelated material.
  • Exposed the new fields in JSON/debug/API payload contracts.
  • Added tests for longer, shorter, and acceptable-duration cases.
  • Updated strict JSON/debug contract fixtures.

Tests

Not run locally in this environment: repository execution is handled through GitHub connector only here. The previous CI run for PR1.2 was green after contract fixes, and this PR is limited to additive duration diagnostic fields plus matching tests.

@kymuco kymuco merged commit 953d87d into main May 30, 2026
1 check passed
@kymuco kymuco mentioned this pull request May 31, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PR1.3] Duration mismatch diagnostic

1 participant